Skip to content

Add windows-11-arm runner#110

Closed
rycont wants to merge 4 commits into
deevus:mainfrom
rycont:main
Closed

Add windows-11-arm runner#110
rycont wants to merge 4 commits into
deevus:mainfrom
rycont:main

Conversation

@rycont
Copy link
Copy Markdown

@rycont rycont commented Nov 5, 2025

  • Add 'os' variant to the build matrix
  • Make 'os' options to be 'windows-11-arm'(new), 'windows-latest'(original)

@rycont
Copy link
Copy Markdown
Author

rycont commented Nov 5, 2025

It closes #39

Comment thread .github/workflows/build.yml Outdated
Co-authored-by: Simon Hartcher <simon@simonhartcher.com>
@rycont
Copy link
Copy Markdown
Author

rycont commented Nov 5, 2025

It was my fault, thanks. Applied it.

@deevus
Copy link
Copy Markdown
Owner

deevus commented Nov 5, 2025

Thanks for this PR! It's looking good. When we create releases, we grab the artifacts from the build step to package them. With the introduction of ARM builds, we need to ensure the final release assets clearly identify which architecture they're for.

Current releases (x64 only):

zed.zip
zed-opengl.zip
cli.zip

What we need with ARM support:

zed-x64.zip
zed-arm64.zip
zed-opengl-x64.zip
zed-opengl-arm64.zip
cli-x64.zip
cli-arm64.zip

To achieve this, we need to include the architecture in the artifact names during the build step. Here's the build matrix that would be created:

Build Type Architecture Artifact Name → Final Release Asset
editor-dx11 x64 (windows-latest) editor-dx11-x64-release zed-x64.zip
editor-dx11 arm64 (windows-11-arm) editor-dx11-arm64-release zed-arm64.zip
editor-opengl x64 (windows-latest) editor-opengl-x64-release zed-opengl-x64.zip
editor-opengl arm64 (windows-11-arm) editor-opengl-arm64-release zed-opengl-arm64.zip
cli x64 (windows-latest) cli-x64-release cli-x64.zip
cli arm64 (windows-11-arm) cli-arm64-release cli-arm64.zip

This way users can clearly see which version they need to download for their system architecture.

Could you update the PR to add architecture to the artifact names in the matrix?

Important: After this is released, we'll need to update the Scoop manifests as they will be broken with this change. Existing manifests will still work but auto-update will fail due to the renamed release assets.

@deevus
Copy link
Copy Markdown
Owner

deevus commented Nov 5, 2025

Files that need updating to merge this PR:

  1. .github/workflows/build.yml - Update the matrix to include architecture in artifact names
  2. .github/workflows/release.yml - Lines 41-53: Update artifact path checks to include architecture variants (e.g., cli-x64-release, cli-arm64-release)
  3. scripts/prepare-release.sh - Lines 15-33: Update to handle architecture-specific artifact names and create arch-specific release zips (e.g., zed-x64.zip, zed-arm64.zip)

@deevus
Copy link
Copy Markdown
Owner

deevus commented Nov 5, 2025

Please also look at updating the tests.

@rycont
Copy link
Copy Markdown
Author

rycont commented Nov 5, 2025

If this change will make scoop break, what about not changing current x64 binary name? Or am I misleading?

@deevus
Copy link
Copy Markdown
Owner

deevus commented Nov 5, 2025

If this change will make scoop break, what about not changing current x64 binary name? Or am I misleading?

I think it makes sense to update the filenames. Updating scoop will be easy.

@deevus
Copy link
Copy Markdown
Owner

deevus commented Nov 7, 2025

#111 will likely be merged first, and will affect this PR. Please take a look.

@deevus
Copy link
Copy Markdown
Owner

deevus commented Nov 13, 2025

Hi @rycont are you available to continue working on this?

@deevus
Copy link
Copy Markdown
Owner

deevus commented May 31, 2026

Closing this as stale. Thanks for the contribution.

@deevus deevus closed this May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants